Clean up Python mutator temp dir after run#5522
Open
simonfaltum wants to merge 4 commits into
Open
Conversation
Without DATABRICKS_BUNDLE_TMP set, every run of the Python mutator left a -python* temp dir containing the full serialized bundle config in the system temp dir. Remove it once the subprocess output has been consumed. User-specified DATABRICKS_BUNDLE_TMP locations are kept for inspection. Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: b7faa0d
24 interesting tests: 15 SKIP, 7 KNOWN, 2 flaky
Top 28 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found during a full-repo review of the CLI. When
DATABRICKS_BUNDLE_TMPis not set, the Python mutator creates a temp directory per run for the files it exchanges with the Python subprocess and never removes it. Everybundle validate/deployon a bundle that uses Python leaves a-python*directory in the system temp dir, and itsinput.jsoncontains the full serialized bundle configuration.Changes
Before, the temp directory leaked on every run; now it is removed once the subprocess output has been consumed.
createCacheDirreturns a cleanup function alongside the directory, and the mutator defers it. When the user setsDATABRICKS_BUNDLE_TMP, the directory is a user-chosen location and is kept for inspection, same as before.Test plan
TestCreateCacheDirinbundle/config/mutator/pythoncovering both branches: temp dir removed by cleanup,DATABRICKS_BUNDLE_TMPdir keptgo test ./bundle/config/mutator/python/passesTestAccept/bundle/python/resolve-variablepasses for all four variants (both engines, bothdatabricks-bundlesversions), exercising the real subprocess flow with cleanup in place./task fmt-q,./task lint-q,./task checkspassThis pull request and its description were written by Isaac.